Feature #2627
unit tests for standard downloader functions
| Status: | New | Start date: | 11/21/2013 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 0% | |
| Category: | - | |||
| Target version: | - | |||
| Component: |
Description
Since we'll be modifying the downloader code a lot, it would be good to first write some JUnit tests of that functionality to be sure we're not breaking anything.
here's some related code/comments:
https://gitorious.org/f-droid/fdroidclient/merge_requests/29
Related issues
Associated revisions
test index.jar signature checking
I got scared by seeing the Android docs' version of JarFile.getInputStream,
which didn't mention SecurityException or the signature checking. But it
seems that even tho its not in the Android docs, Android implements it the
same as Java does. It is good to have these tests in place anyhow, since
this is an essential piece of the security process of FDroid.
- http://docs.oracle.com/javase/6/docs/api/java/util/jar/JarFile.html#getInputStream(java.util.zip.ZipEntry)
- https://developer.android.com/reference/java/util/jar/JarFile.html#getInputStream(java.util.zip.ZipEntry)
refs #2627 https://dev.guardianproject.info/issues/2627
refs #2959 https://dev.guardianproject.info/issues/2959
History
#1 Updated by hans almost 4 years ago
- Target version changed from 0.2 - ChatSecure/Bluetooth to Integrate Kerplapp into FDroid
#2 Updated by hans almost 4 years ago
there is now an Android Test Project in fdroidclient/test
#3 Updated by hans over 3 years ago
- Target version changed from Integrate Kerplapp into FDroid to new unified Downloader infrastructure
#4 Updated by hans over 3 years ago
- Target version changed from new unified Downloader infrastructure to 134
#5 Updated by hans over 2 years ago
- Target version deleted (
134)