Bug #3020
Crash on repo creation (Samsung Device)
| Status: | Closed | Start date: | 03/02/2014 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | hans | % Done: | 0% | |
| Category: | - | |||
| Target version: | improved security/usability | |||
| Component: |
Description
@ E/AndroidRuntime(22077): FATAL EXCEPTION: ModernAsyncTask #1
7730 E/AndroidRuntime(22077): java.lang.RuntimeException: An error occured while executing doInBackground()
7731 E/AndroidRuntime(22077): >at android.support.v4.content.ModernAsyncTask$3.done(ModernAsyncTask.java:137)
7732 E/AndroidRuntime(22077): >at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:352)
7733 E/AndroidRuntime(22077): >at java.util.concurrent.FutureTask.setException(FutureTask.java:219)
7734 E/AndroidRuntime(22077): >at java.util.concurrent.FutureTask.run(FutureTask.java:239)
7735 E/AndroidRuntime(22077): >at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1080)
7736 E/AndroidRuntime(22077): >at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:573)
7737 E/AndroidRuntime(22077): >at java.lang.Thread.run(Thread.java:841)
7738 E/AndroidRuntime(22077): Caused by: java.lang.NullPointerException
7739 E/AndroidRuntime(22077): >at net.binaryparadox.kerplapp.AppListLoader.loadInBackground(AppListLoader.java:108)
7740 E/AndroidRuntime(22077): >at net.binaryparadox.kerplapp.AppListLoader.loadInBackground(AppListLoader.java:39)
7741 E/AndroidRuntime(22077): >at android.support.v4.content.AsyncTaskLoader.onLoadInBackground(AsyncTaskLoader.java:242)
7742 E/AndroidRuntime(22077): >at android.support.v4.content.AsyncTaskLoader$LoadTask.doInBackground(AsyncTaskLoader.java:51)
7743 E/AndroidRuntime(22077): >at android.support.v4.content.AsyncTaskLoader$LoadTask.doInBackground(AsyncTaskLoader.java:40)
7744 E/AndroidRuntime(22077): >at android.support.v4.content.ModernAsyncTask$2.call(ModernAsyncTask.java:123)
7745 E/AndroidRuntime(22077): >at java.util.concurrent.FutureTask.run(FutureTask.java:234)
7746 E/AndroidRuntime(22077): >... 3 more
7747 I
E/AndroidRuntime(22077): FATAL EXCEPTION: ModernAsyncTask #1
7730 E/AndroidRuntime(22077): java.lang.RuntimeException: An error occured while executing doInBackground()
7731 E/AndroidRuntime(22077): >at android.support.v4.content.ModernAsyncTask$3.done(ModernAsyncTask.java:137)
7732 E/AndroidRuntime(22077): >at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:352)
7733 E/AndroidRuntime(22077): >at java.util.concurrent.FutureTask.setException(FutureTask.java:219)
7734 E/AndroidRuntime(22077): >at java.util.concurrent.FutureTask.run(FutureTask.java:239)
7735 E/AndroidRuntime(22077): >at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1080)
7736 E/AndroidRuntime(22077): >at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:573)
7737 E/AndroidRuntime(22077): >at java.lang.Thread.run(Thread.java:841)
7738 E/AndroidRuntime(22077): Caused by: java.lang.NullPointerException
7739 E/AndroidRuntime(22077): >at net.binaryparadox.kerplapp.AppListLoader.loadInBackground(AppListLoader.java:108)
7740 E/AndroidRuntime(22077): >at net.binaryparadox.kerplapp.AppListLoader.loadInBackground(AppListLoader.java:39)
7741 E/AndroidRuntime(22077): >at android.support.v4.content.AsyncTaskLoader.onLoadInBackground(AsyncTaskLoader.java:242)
7742 E/AndroidRuntime(22077): >at android.support.v4.content.AsyncTaskLoader$LoadTask.doInBackground(AsyncTaskLoader.java:51)
7743 E/AndroidRuntime(22077): >at android.support.v4.content.AsyncTaskLoader$LoadTask.doInBackground(AsyncTaskLoader.java:40)
7744 E/AndroidRuntime(22077): >at android.support.v4.content.ModernAsyncTask$2.call(ModernAsyncTask.java:123)
7745 E/AndroidRuntime(22077): >at java.util.concurrent.FutureTask.run(FutureTask.java:234)
7746 E/AndroidRuntime(22077): >... 3 more
7747 I
9127 D/CrashAnrDetector( 473): processName: net.binaryparadox.kerplapp
9128 D/CrashAnrDetector( 473): broadcastEvent : net.binaryparadox.kerplapp data_app_crash
I/ActivityManager( 473): Process net.binaryparadox.kerplapp (pid 22303) (adj 0) has died.@
Associated revisions
Fix crash on Samsung device from missing PackageInfo.
It seems on some devices there can be a ApplicationInfo object, but we
can't get an AppInfo object for the corresponding package from
PackageManager.getPackageInfo(). This was causing a NPE where we assumed
the AppInfo object would never be null.
The fix is skipping apps that don't have an AppInfo. We need this
structure to be able to learn the version code and other necessary
information for the repo index.
I believe this fixes Issue #3020.
History
#1 Updated by pd0x almost 4 years ago
- Status changed from New to Feedback
- Assignee set to hans
I think I've fixed this issue with: https://github.com/binaryparadox/Kerplapp/commit/8b9a1b8a00a39970d99eb3d2dbb4ad94665906f1
#2 Updated by pd0x almost 4 years ago
Tested fix. Works. Please review.
#3 Updated by hans almost 4 years ago
- Status changed from Feedback to Closed
- Target version set to improved security/usability