Bug #2345: keysync GUI crash on start - KeySync - Guardian Project Dev (ARCHIVED SITE)

Copy

Bug #2345

keysync GUI crash on start

Added by Anonymous about 4 years ago. Updated about 4 years ago.

Status:

Closed

Start date:

11/05/2013

Priority:

Normal

Due date:

Assignee:

abeluck

% Done:

Category:

Target version:

0.2.1

Component:

Description

Starting keysync-gui on Ubuntu 12.04 (latest updates), the application crashes immediately. If started via terminal I get the following traceback:

File "/usr/bin/keysync-gui", line 550, in &lt;module&gt;
    ROOT = App()
  File "/usr/bin/keysync-gui", line 84, in init
    img = Image.open(os.path.join(self.find_iconsdir(), 'keysync.png'))
  File "/usr/lib/python2.7/dist-packages/PIL/Image.py", line 1952, in open
    fp = builtin.open(fp, "rb")
IOError: [Errno 2] No such file or directory: '/usr/bin/../share/keysync/keysync.png'

Associated revisions

Revision 6eaf9f07
Added by Hans-Christoph Steiner about 4 years ago

include keysync.png in iconsdir with the rest of the icons

Yes, this is making an installed copy of the file, but its an easy fix.
Disk space is cheap. In the long run, this should probably follow all the
XDG standards, using python-xdg, etc.

refs #2345

Revision 6eaf9f07
Added by Hans-Christoph Steiner about 4 years ago

include keysync.png in iconsdir with the rest of the icons

Yes, this is making an installed copy of the file, but its an easy fix.
Disk space is cheap. In the long run, this should probably follow all the
XDG standards, using python-xdg, etc.

refs #2345

Revision a3700b93
Added by Hans-Christoph Steiner about 4 years ago

provide symlink to keysync.png where keysync-gui expects it

refs #2345 (upstream bug):
https://dev.guardianproject.info/issues/2345

History

#1 Updated by abeluck about 4 years ago

They are being installed in /usr/share/icons/hicolor/256x256/apps/ as per setup.py We need to detect the apps at runtime in this prefix. I wonder if there is some sort of opendesktop library for python?

#2 Updated by abeluck about 4 years ago

Yup there is a library python-xdg

Specifically we should use xdg.IconTheme.getIconPath (see http://pyxdg.readthedocs.org/en/latest/icontheme.html)

Of course only Linux systems should depend on this library.

#3 Updated by hans about 4 years ago

I suppose in the long run we should use python-xdg, but that seems like more than we need right now since the install path is hard-coded in setup.py.

#4 Updated by hans about 4 years ago

Status changed from New to Resolved
Assignee set to abeluck

I fixed this in the keysync git and in the Debian/Ubuntu package. It was a silly oversight on my part, sorry about that.

#5 Updated by abeluck about 4 years ago

Status changed from Resolved to Closed

Indeed, ideally the app icon should be in /usr/share/icons/* to conform to the linux desktop standard, but we already are installing assets it /usr/share/keysync anyways, so this is fine for now.

Reviewed and pushed.

#6 Updated by abeluck about 4 years ago

Target version set to 0.2.1