Bug #2043

win32: icon detection is broken

Added by abeluck over 4 years ago. Updated over 4 years ago.

Status:ClosedStart date:10/09/2013
Priority:NormalDue date:
Assignee:abeluck% Done:

0%

Category:-
Target version:0.2
Component:

Description

icon detection is broken in windows.. here's the log with some added output

$ ./dist/keysync-gui/keysync-gui.exe

find_iconsdir paths=
['c:\\Users\\abel\\DOCUME~1\\keysync\\dist\\KEYSYN~1\\share\\keysync', 'c:\\User
s\\abel\\DOCUME~1\\keysync\\dist\\KEYSYN~1\\..\\share\\keysync', 'c:\\Users\\abe
l\\DOCUME~1\\keysync\\dist\\KEYSYN~1\\icons']
Could not find icons dir!
Traceback (most recent call last):
  File "<string>", line 483, in <module>
  File "<string>", line 66, in __init__
  File "<string>", line 164, in setupwindow
  File "c:\Users\abel\Documents\keysync\build\keysync-gui\out00-PYZ.pyz\ntpath",
 line 96, in join
TypeError: object of type 'NoneType' has no len()

Associated revisions

Revision 0607077e
Added by Abel Luck over 4 years ago

win32: include icons as resources in the pyinstaller bundle fixes #2043

pyinstaller provides a special way to bundle and later access data
files. See the "Adding Files to the Bundle" section in the pyinstaller
docs.

Revision 0607077e
Added by Abel Luck over 4 years ago

win32: include icons as resources in the pyinstaller bundle fixes #2043

pyinstaller provides a special way to bundle and later access data
files. See the "Adding Files to the Bundle" section in the pyinstaller
docs.

History

#1 Updated by hans over 4 years ago

  • Status changed from New to In Progress

#2 Updated by abeluck over 4 years ago

  • Status changed from In Progress to Resolved

This was fixed in 0607077e37949d423dbdcc67df7c5ec74ac73556 but my commit tagging failed :(

#3 Updated by abeluck over 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF