Bug #1987

Many crashes in CacheWord SQLCipher Open Helper

Added by n8fr8 over 4 years ago. Updated about 4 years ago.

Status:ClosedStart date:10/03/2013
Priority:HighDue date:
Assignee:devrandom% Done:

0%

Category:-
Target version:v12 - March Mantra
Component:

Description

From HOckeyApp... any thoughts on this? Should we recruit Abel?

info.guardianproject.cacheword.SQLCipherOpenHelper.encodeRawKey
in SQLCipherOpenHelper.java, line 86
Reason: java.lang.NullPointerException
Number of Crashes
34
Percentage for Version
31.19%
Jailbroken
-
Last Crash At
03 Oct 2013, 00:52
Stacktrace
Histogram
Devices
OS Versions
Exception Backtrace:
1 info.guardianproject.cacheword.SQLCipherOpenHelper.encodeRawKey SQLCipherOpenHelper.java, line 86
2 info.guardianproject.otr.app.im.app.ImApp.initOtrStoreKey ImApp.java, line 453
3 info.guardianproject.otr.app.im.app.WelcomeActivity.openEncryptedStores WelcomeActivity.java, line 544
4 info.guardianproject.otr.app.im.app.WelcomeActivity.onCacheWordOpened WelcomeActivity.java, line 533
5 info.guardianproject.cacheword.CacheWordHandler.checkCacheWordState CacheWordHandler.java, line 193
6 info.guardianproject.cacheword.CacheWordHandler.access$1 CacheWordHandler.java, line 169
7 info.guardianproject.cacheword.CacheWordHandler$2.onServiceConnected CacheWordHandler.java, line 239
8 android.app.LoadedApk$ServiceDispatcher.doConnected

Associated revisions

Revision 9405b18a
Added by devrandom over 4 years ago

Don't try to set empty password in WelcomeActivity when already open

fixes #1987

History

#1 Updated by devrandom over 4 years ago

Do we know if this happens with latest version? Does HockeyApp maintain versions?

#2 Updated by devrandom over 4 years ago

It is possible that the mCacheWord in ImApp is different than the mCacheWord in WelcomeActivity. Maybe should review that part of the code and/or add defensive checks to narrow this down. We don't know anybody personally that's experiencing this?

#3 Updated by chatsecure over 4 years ago

I already encountered a lot of crashes, but I do not know if they were related to this. How can I find out?

#4 Updated by devrandom over 4 years ago

Under what circumstances (i.e. what were you doing at the time)?

#5 Updated by chatsecure over 4 years ago

I already filed the most of the crashes I had in here.

1.) Closing app in recent apps leads to crash.
2.) When app crashed bec. of closure in recent apps it reappears in notificaions , but you can only open it by opening the app again. Then of you try to open contacts of an account the app crashes.
3.) Once the app crashed when trying to send a picture via file intent, but this may have been after a crash described in 1.)
4.) Signing all out and pressing back at the passphrase page leads to crash.
5.) Pressing yes to install QR-Scanner leads to crash.

This is all I have in mind now.

#6 Updated by devrandom over 4 years ago

chatsecure, n8fr8 - when swiping the app away from recent app, is the desired action that the user is logged out of all accounts, or just that it doesn't crash on re-entry?

#7 Updated by chatsecure over 4 years ago

I would prefer if CS keeps running even if swiped away from recent apps. If somebody wants to exit CS one can use the new sign out all/exit function. I do not know how it should work at the current build v12.5, but CS still exits and restarts when swiping away in recent apps. And after it restarted you can not start it by tapping on the notification (a window pops up for a second and disappears again) but have to start the app again by tapping on the CS symbol in the apps list/desktop. I.e. the Bug #1927 is not resolved completely.

#8 Updated by devrandom over 4 years ago

  • Status changed from New to Resolved

This is ready for testing (after next build).

#9 Updated by n8fr8 about 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF