Copy

Task #3718

remove CacheWordSettings, all config is handled by CacheWordHandler

Added by hans over 3 years ago. Updated over 3 years ago.

Status:ClosedStart date:09/05/2014
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-
Target version:0.1
Component:

Description

CacheWordSettings seems to have been created mostly as a means to handle all of the customization of the built-in Notification. Now that is it up to the app to supply the Notification, CacheWordSettings is mostly adding complexity, since it is only handling the timeout and the

I propose removing CacheWordSettings entirely, and moving the remaining setters and getters to CacheWordHandler. Since I've already removed CacheWordActivityHandler since it was a pointless wrapper, this would leave CacheWordHandler as the sole class that CacheWord users would have to interact with.

Sound worth the API change?

Associated revisions

Revision 9a18b086
Added by Hans-Christoph Steiner over 3 years ago

purge CacheWordSettings and directly set timeout in CacheWordHandler

This removes the now pointless CacheWordSettings and provides options for
directly setting the timeout in seconds. This changes the meaning of the
non-positive values:

0 = timeout in seconds

0 = disable timeout
<0 = use default value

fixes #3718 https://dev.guardianproject.info/issues/3718

History

#1 Updated by hans over 3 years ago

  • Target version changed from 0.2 to 0.1

#2 Updated by Anonymous over 3 years ago

  • Status changed from New to Resolved

Applied in changeset cacheword|commit:9a18b086d1268a713b5f536afe60132c86662a89.

#3 Updated by hans over 3 years ago

  • Status changed from Resolved to Closed
Copy

Also available in: Atom PDF