Feature #2926
make RepoProvider.Helper take Context rather than ContentResolver
| Status: | Closed | Start date: | 01/31/2014 | |
|---|---|---|---|---|
| Priority: | Low | Due date: | ||
| Assignee: | hans | % Done: | 0% | |
| Category: | - | |||
| Target version: | 0.2 - ChatSecure/Bluetooth | |||
| Component: |
Description
On 2014-01-24 11:12, Hans-Christoph Steiner wrote:
Hope you're enjoying camping! I have a small suggestion: if
RepoProvider.Helper.findById()usedContextinstead ofContentResolver, it
might be a little simpler.
Sounds like a good idea to me. Thanks. Especially given that a Context gets passed around the rest of the Android framework, and the main (only?) way that a user of RepoProvider.Helper.* functions would get a reference to a ContentResolver is through a Context.
Could you submit a merge request with that patch? I'll make sure the other [App|Apk]Provider.Helper.* methods abide by the same principle.
cheers,
pete.
Associated revisions
make RepoProvider.Helper take Context rather than ContentResolver
This makes the code a bit neater, and passing the Context around is a
common pattern.
make ApkProvider.Helper take Context rather than ContentResolver
This makes the code a bit neater, and passing the Context around is a
common pattern.
History
#1 Updated by hans almost 4 years ago
- Priority changed from Normal to Low
- Target version set to Integrate Kerplapp into FDroid
#2 Updated by hans almost 4 years ago
- Status changed from New to In Progress
- Assignee set to hans
- Target version changed from Integrate Kerplapp into FDroid to 0.2 - ChatSecure/Bluetooth
#3 Updated by hans almost 4 years ago
- Status changed from In Progress to Resolved
#4 Updated by hans almost 4 years ago
- Status changed from Resolved to Closed