Bug #1181
Gibberbot binds resource before trying stream resumption
| Status: | Closed | Start date: | 04/24/2013 | |
|---|---|---|---|---|
| Priority: | High | Due date: | ||
| Assignee: | devrandom | % Done: | 0% | |
| Category: | - | |||
| Target version: | v12 - March Mantra | |||
| Component: |
Description
Below is a piece of log from a just restarted prosody showing showing a client running Gibberbot doing resource binding before trying to resume a stream. XEP-0198 says that the client should send <resume/> right after authentication. It may however bind a new resource if resumption failed.
c2sa56e738 info Client connected c2sa56e738 debug Client sent opening <stream:stream> to <HOST> c2sa56e738 debug Sent reply <stream:stream> to client c2sa56e738 debug Received[c2s_unauthed]: <starttls xmlns='urn:ietf:params:xml:ns:xmpp-tls'> c2sa56e738 debug TLS negotiation started for c2s_unauthed... c2sa56e738 debug Client sent opening <stream:stream> to <HOST> c2sa56e738 debug Sent reply <stream:stream> to client c2sa56e738 debug Received[c2s_unauthed]: <auth mechanism='PLAIN' xmlns='urn:ietf:params:xml:ns:xmpp-sasl'> c2sa56e738 info Authenticated as <USER>@<HOST> <HOST>:saslauth debug sasl reply: <success xmlns='urn:ietf:params:xml:ns:xmpp-sasl'></success> c2sa56e738 debug Client sent opening <stream:stream> to <HOST> c2sa56e738 debug Sent reply <stream:stream> to client c2sa56e738 debug Received[c2s]: <iq id='cxz1A-106' type='set'> rostermanager debug load_roster: asked for: <USER>@<HOST> c2sa56e738 debug Resource bound: <USER>@<HOST>/65d91486-d512-41e3-835b-2faf0958bfd1 c2sa56e738 debug Received[c2s]: <iq id='cxz1A-107' type='set'> c2sa56e738 debug Received[c2s]: <resume h='26' previd='fba95064-b14b-4a53-8cba-9d3f502a5aa0' xmlns='urn:xmpp:sm:2'> c2sa56e738 debug Tried to resume after resource binding c2sa56e738 info Client disconnected: closed c2sa56e738 debug Destroying session for <USER>@<HOST>/65d91486-d512-41e3-835b-2faf0958bfd1 (<USER>@<HOST>): closed
Associated revisions
History
#1 Updated by devrandom over 4 years ago
- Priority changed from Normal to High
Strange, I could swear this was looked at and fixed long ago.
Note for later: look at https://github.com/ge0rg/smack/commit/38e3b05636aa678bbe2ef6a1b6e8e620cae01d0d
#2 Updated by devrandom over 4 years ago
if (resource == null) return;
and also:
bind ? config.getResource() : null
#3 Updated by devrandom over 4 years ago
- Status changed from New to In Progress
- Assignee set to devrandom
- Target version set to v12 - March Mantra
#4 Updated by devrandom over 4 years ago
- Status changed from In Progress to Resolved
#5 Updated by n8fr8 about 4 years ago
- Status changed from Resolved to Closed