Bug #5797

Zom: Result of existing account login not checked

Added by Anonymous over 2 years ago.

Status:NewStart date:09/16/2015
Priority:HighDue date:
Assignee:-% Done:

0%

Category:-
Target version:-
Component:

Description

Zom doesn't notify a user if logging into an existing account failed. In the snippet below from OnBoardingActivity#ExistingAccountTask we see that app proceeds to the invite screen regardless of the sign in result.

private class ExistingAccountTask extends AsyncTask<String, Void, OnboardingAccount> {
...
        @Override
        protected void onPostExecute(OnboardingAccount account) {

            mFullUserName = account.username + '@' + account.domain;

            SignInHelper signInHelper = new SignInHelper(OnboardingActivity.this, mHandler);
            signInHelper.activateAccount(account.providerId,account.accountId);
            signInHelper.signIn(account.password, account.providerId, account.accountId, true);

            showInviteScreen();
        }
}

This allows the app to report an active user account based on invalid credentials.

zom_bad_acct.png - Me screen after choosing "login existing account" and entering invalid credentials. (87.2 KB) Anonymous, 09/16/2015 07:50 pm

Also available in: Atom PDF